You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OK, there are a bunch of scripts which do some complicated stuff for testing:
-rwxrwxr-x 1 ed ed 741 Dec 12 06:42 run_all_tests.sh
-rwxrwxr-x 1 ed ed 736 Dec 12 06:42 run_all_tests_theia.sh
-rwxrwxr-x 1 ed ed 4909 Dec 12 06:42 test_cnvgrib_theia.sh
-rwxrwxr-x 1 ed ed 4566 Dec 12 06:42 test_cnvgrib_wcoss.sh
-rwxrwxr-x 1 ed ed 7123 Dec 12 06:42 test_copygb2_theia.sh
-rwxrwxr-x 1 ed ed 6818 Dec 12 06:42 test_copygb2_wcoss.sh
-rwxrwxr-x 1 ed ed 4414 Dec 12 06:42 test_nam_file_cnvgrib_theia.sh
-rwxrwxr-x 1 ed ed 4049 Dec 12 06:42 test_nam_file_cnvgrib_wcoss.sh
-rwxrwxr-x 1 ed ed 7648 Dec 12 06:42 test_wgrib2_theia.sh
-rwxrwxr-x 1 ed ed 7413 Dec 12 06:42 test_wgrib2_wcoss.sh
-rwxrwxr-x 1 ed ed 3475 Dec 12 06:42 test_wgrib_wcoss.sh
When I look at these tests, they seem to use some data already existing on wcoss/theia. They run some of the grib_util commands but don't seem to check the output - if the command completes, then the test passes.
Looks like these tests will be too difficult to recover and will be removed. @BoiVuong-NOAA if you would like to attempt to recover these tests and keep them in use:
The data files must be small and committed to the tests directory.
The test must not be machine specific, but run on all Unix machines.
The test must check output for correctness, not just assume everything worked if there is not a crash. ;-)
I see we have some tests. We need to get them running with cmake not with scripts, and have them run by the CI.
See NOAA-EMC/NCEPLIBS#130
The text was updated successfully, but these errors were encountered: