Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip_4 must handle double-precision arguments #257

Open
edwardhartnett opened this issue Oct 11, 2024 · 2 comments
Open

ip_4 must handle double-precision arguments #257

edwardhartnett opened this issue Oct 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

We should not need ip_d builds. Double-precisions libraries should not be required.

@webisu @AlexanderRichert-NOAA @AlysonStahl-NOAA

@edwardhartnett edwardhartnett added the enhancement New feature or request label Oct 11, 2024
@AlexanderRichert-NOAA
Copy link
Contributor

Do you envision the _4 build using double precision under the hood for doing the interpolation, or would it all be 4 byte?

@edwardhartnett
Copy link
Contributor Author

Double precision should be used when double arguments are used.

In other words, it should accept arguments as 4-byte reals, and as 8-byte reals, and should use 4-byte or 8-byte math accordingly.

So one library, the _4, should be able to handle all _4 and _d needs. We would then just build the _4 and everyone would use that, there would be no _d build.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants