Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tarballs from repo and distribution #65

Closed
edwardhartnett opened this issue Dec 7, 2023 · 0 comments
Closed

remove tarballs from repo and distribution #65

edwardhartnett opened this issue Dec 7, 2023 · 0 comments
Labels
build Relates to the build system

Comments

@edwardhartnett
Copy link
Contributor

edwardhartnett commented Dec 7, 2023

Once #64 is working, remove the tarballs from the build.

Certainly we don't want large binary files in the repo, since these tarballs are readily available elsewhere.

We also do not want to install any libraries that are not present. By doing this, we are using old versions of the libraries, which have not been approved or installed by system admins.

For example, on all NOAA systems, there is a copy of netCDF, and it has been approved and installed (correctly) by the system administrators. Everyone needs to use that install of netCDF, no one should be installing their own copy of netCDF under any circumstances. If the system install of netCDF is not adequate (and we can check this in the cmake file), we stop the build and tell the user to get a proper netCDF install before trying again.

From the sysadmins point of view, they cannot have everyone installing their own copies of netCDF, it's wasteful and dangerous.

From the programming point of view, it makes debugging confusing, because the programmer assumes wgrib2 is using the system install of netCDF (like every other application does) and will not be aware that wgrib2 has its own copy of (a different version of) netCDF. Hilarious confusion may ensue.

@edwardhartnett edwardhartnett added the build Relates to the build system label Dec 7, 2023
@edwardhartnett edwardhartnett changed the title remove tarballs from repo remove tarballs from repo and distribution Dec 7, 2023
@edwardhartnett edwardhartnett moved this to Ready in wgrib2-3.2.0 Dec 18, 2023
@AlysonStahl-NOAA AlysonStahl-NOAA moved this from Ready to Done in wgrib2-3.2.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Relates to the build system
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants