Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diag integral error during output with intel 2024.2 #1623

Open
rem1776 opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1624
Open

diag integral error during output with intel 2024.2 #1623

rem1776 opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1624

Comments

@rem1776
Copy link
Contributor

rem1776 commented Dec 5, 2024 •
edited
Loading

Describe the bug
The diag_integral unit tests are failing when compiled with oneapi 2024.2 (ifort+icx) and debug flags. The culprit seems to be this attempt at a list comprehension when it writes out field averages:

FMS/diag_integral/diag_integral.F90

Lines 778 to 784 in 899ea6e

if (diag_unit /= 0) then
write (diag_unit,format_data(1:nd)) &
xtime, (field_avg(i),i=nst,nend)
else
write (*, format_data(1:nd)) &
xtime, (field_avg(i),i=nst,nend)
endif

This isn't valid fortran as far as i know so I have no idea how its working.

To Reproduce
compile with oneapi 2024.2 and debug flags (FCFLAGS=-traceback -g -O0 -check -check noarg_temp_created -check nopointer -warn -warn noerrors -fpe0 -ftrapuv)

Expected behavior
Code shouldn't crash with debug flags.

System Environment
AMD dev box

Additional context
The format code used in the output seems like it needs some adjusting, otherwise this would be a much easier fix
@rem1776 rem1776 linked a pull request Dec 5, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix format string overflow in diag_integral test rem1776/FMS
1 participant
@rem1776