Skip to content

Commit

Permalink
Removed default for mandatory time scale in OBCs
Browse files Browse the repository at this point in the history
Removed two instances of `fail_if_missing=.true., default=0.` which
are contradictory: a default value is meaningless if the parameter must
be specified.

I encountered this when adding the `defaults=` option to `get_param_real_array()`.
  • Loading branch information
adcroft committed Dec 5, 2024
1 parent ac6e43d commit cfb53f1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/MOM_open_boundary.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ subroutine setup_u_point_obc(OBC, G, US, segment_str, l_seg, PF, reentrant_y)
"Timescales in days for nudging along a segment, "//&
"for inflow, then outflow. Setting both to zero should "//&
"behave like SIMPLE obcs for the baroclinic velocities.", &
fail_if_missing=.true., default=0., units="days", scale=86400.0*US%s_to_T)
fail_if_missing=.true., units="days", scale=86400.0*US%s_to_T)
OBC%segment(l_seg)%Velocity_nudging_timescale_in = tnudge(1)
OBC%segment(l_seg)%Velocity_nudging_timescale_out = tnudge(2)
deallocate(tnudge)
Expand Down Expand Up @@ -1620,7 +1620,7 @@ subroutine setup_v_point_obc(OBC, G, US, segment_str, l_seg, PF, reentrant_x)
"Timescales in days for nudging along a segment, "//&
"for inflow, then outflow. Setting both to zero should "//&
"behave like SIMPLE obcs for the baroclinic velocities.", &
fail_if_missing=.true., default=0., units="days", scale=86400.0*US%s_to_T)
fail_if_missing=.true., units="days", scale=86400.0*US%s_to_T)
OBC%segment(l_seg)%Velocity_nudging_timescale_in = tnudge(1)
OBC%segment(l_seg)%Velocity_nudging_timescale_out = tnudge(2)
deallocate(tnudge)
Expand Down

0 comments on commit cfb53f1

Please sign in to comment.