Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-reproducibility across layouts in tracer advection #518

Closed
kshedstrom opened this issue Nov 8, 2023 · 3 comments
Closed

Non-reproducibility across layouts in tracer advection #518

kshedstrom opened this issue Nov 8, 2023 · 3 comments

Comments

@kshedstrom
Copy link

For the Bering domain, answers match for 21 vs. 24 cores, but not for 126 vs. 128 cores. The DEBUG output points to Post-advect temp and salt. This is with the PPM:H3 advection scheme. Changing the stencil to 3 in MOM_tracer_advect.F90 seems to fix it. Does this make sense? @Hallberg-NOAA
@kshedstrom
Copy link
Author

Trying the PPM scheme does not reproduce either. I see temperature differences at one spot near the open boundary, at the bottom.

@kshedstrom
Copy link
Author

The tracer reservoirs update with uhtr, vhtr, which are limited to two points of valid information in the halo. This is determined in lines mom-ocean#1033-1038 of MOM_dynamics_split.F90. If we need more points, we can add a pass_vector for tres_x, tres_y after they get updated in update_segment_tracer_reservoirs.

@kshedstrom kshedstrom mentioned this issue Nov 16, 2023
Merged
@theresa-cordero
Copy link

This was addressed by PR #520 for temperature and salinity, and PR #577 for generic tracers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kshedstrom @Hallberg-NOAA @theresa-cordero