Skip to content

Commit

Permalink
Bugfix: uninitialized variables domore_u, domore_v
Browse files Browse the repository at this point in the history
- Reported by @nicjhan in issue CommerceGoc/NOAA-GFDL-MOM6#149.
- As for MOM_tracer_advect, these logicals are not touched
  everywhere and work properly even if they have random state on
  the first pass because the behavior is overridden by the non-zero
  contents of the mass flux variables. Bizarrely!
- I've initialized them to .false.
- No answer changes.
  • Loading branch information
adcroft committed Apr 28, 2015
1 parent eb1d222 commit 67a04e5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions SIS_tracer_advect.F90
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@ subroutine advect_tracer(Tr, h_prev, h_end, uhtr, vhtr, ntr, dt, G, CS) ! (, OBC

do k=1,ncat
domore_k(k)=1
do j=js,je; domore_u(j,k) = .false.; enddo
do j=js-1,je; domore_v(j,k) = .false.; enddo
! Put the remaining (total) thickness fluxes into uhr and vhr.
do j=js,je ; do I=is-1,ie ; uhr(I,j,k) = dt*uhtr(I,j,k) ; enddo ; enddo
do J=js-1,je ; do i=is,ie ; vhr(i,J,k) = dt*vhtr(i,J,k) ; enddo ; enddo
Expand Down

0 comments on commit 67a04e5

Please sign in to comment.