Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code does not compile if USE_FMS2_IO is undefined #71

Open
Hallberg-NOAA opened this issue Oct 30, 2024 · 1 comment
Open

Code does not compile if USE_FMS2_IO is undefined #71

Hallberg-NOAA opened this issue Oct 30, 2024 · 1 comment
Labels
bug

Comments

@Hallberg-NOAA
Copy link
Member

The dev/gfdl branch of the iceberg no longer compiles when USE_FMS2_IO is undefined, because the routine read_ice_sheet_basins() was only added to icebergs_fms2io.F90, and not to icebergs_fmsio.F90, but it is used regardless of which version of the FMS modules are being used.

This problem was introduced with #70, which was merged into the dev/gfdl branch of the icebergs code on August 21, 2024. The main branch of the icebergs code is not yet afflicted by this bug.
@alex-huth alex-huth mentioned this issue Oct 31, 2024
Open
@alex-huth
Copy link
Contributor

@Hallberg-NOAA , I added you as a reviewer to PR #72 , which should fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hallberg-NOAA @alex-huth