Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design review #436

Closed
randytpierce opened this issue Oct 31, 2024 · 2 comments
Closed

design review #436

randytpierce opened this issue Oct 31, 2024 · 2 comments
Assignees
@randytpierce

Comments

@randytpierce
Copy link
Contributor

randytpierce commented Oct 31, 2024 •
edited
Loading

Design review for GribModelRaobPressureBuilderV01
@randytpierce randytpierce mentioned this issue Oct 31, 2024
Open
@randytpierce
Copy link
Contributor Author

GribModelRaobPressureBuilderV01 will extend GribBuilder. This will necessitate also making GribModelRaobNativeBuilderV01 to build documents that are indexed on native step levels of the model. It also necessitates renaming (and slightly refactoring) the original gribbuilder class for METARS since it was the only grib model builder the heirarchy of the classes needs to be sorted out and common code moved to the parent GribBuilder. There will be three GribBuilder... classes after this.

@randytpierce
Copy link
Contributor Author

This has been incorporated into the docs/reviews/design.md document. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randytpierce randytpierce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randytpierce @mollybsmith-noaa