Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NWIS Client: Expose cache filename as option #175

Closed
jarq6c opened this issue Feb 8, 2022 · 8 comments · Fixed by #176
Closed

NWIS Client: Expose cache filename as option #175

jarq6c opened this issue Feb 8, 2022 · 8 comments · Fixed by #176
Assignees
@jarq6c @aaraney
Labels
enhancement New feature or request

Comments

@jarq6c
Copy link
Collaborator

jarq6c commented Feb 8, 2022

Allow users to set an alternative path for the cache when instantiating IVDataService.

Relevant line here:

hydrotools/python/nwis_client/src/hydrotools/nwis_client/iv.py

Line 89 in 7294aac

_requests_cache_filename = "nwisiv_cache"

@jarq6c jarq6c added the enhancement New feature or request label Feb 8, 2022
@jarq6c jarq6c self-assigned this Feb 8, 2022
@jarq6c jarq6c mentioned this issue Feb 8, 2022
Closed
@aaraney
Copy link
Member

aaraney commented Feb 8, 2022

This is a pretty easy lift. Once #174 is merged, ill open a PR that adds this feature.

@amaes3owp
Copy link

Nice!

@aaraney aaraney mentioned this issue Feb 8, 2022
Merged
10 tasks
@aaraney
Copy link
Member

aaraney commented Feb 8, 2022

@amaes3owp, see #176. Ill post a link to pypi once this PR has been merged in and i've published the new version to pypi.

@amaes3owp
Copy link

Thank you guys for getting this done so quickly!

@aaraney
Copy link
Member

aaraney commented Feb 9, 2022

@amaes3owp, version 3.1.0 of hydrotools.nwis_client is now on pypi. Please upgrade to the latest version using:

pip install hydrotools.nwis-client==3.1.0

@amaes3owp
Copy link

Awesome!!
Thank you for doing this upgrade

@aaraney
Copy link
Member

aaraney commented Feb 9, 2022

Oh yeah of course! Thanks for opening up the ticket!

@jarq6c
Copy link
Collaborator Author

jarq6c commented Feb 9, 2022

Thanks Austin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarq6c jarq6c

@aaraney aaraney

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cache_filename parameter to the NWIS Client constructor aaraney/hydrotools
3 participants
@jarq6c @aaraney @amaes3owp