Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI barriers in IPE? #10

Open
rmontuoro opened this issue Jul 30, 2019 · 6 comments
Open

MPI barriers in IPE? #10

rmontuoro opened this issue Jul 30, 2019 · 6 comments

Comments

@rmontuoro
Copy link
Contributor

A few MPI barriers are used in the refactored IPE code.

We should discuss whether such barriers are required or could be eliminated since they affect runtime performance.

@gmillward
Copy link
Contributor

Is this a problem with IPE running coupled to WAM? If it's just a performance issue then this would seem low-priority, unless the performance is terrible for some reason?

@rmontuoro
Copy link
Contributor Author

It is a low-priority issue, indeed. However, it should be addressed before code delivery since MPI barriers do affect runtime performance and may mask code issues when run in parallel.

@gmillward
Copy link
Contributor

Rafaelle - looking at the code, MPI_barrier is only used (during actual runtime) for writing out the IPE hdf5 'state' files. I think the barrier is in there because Joe had problems with the hdf5 files (ie, they were bogus/corrupted) when there was no barrier. I seem to recall Joe found a few bugs in hdf5 itself....but yeh, if it's a real performance issue then we can see what can be done.

@twfang
Copy link
Contributor

twfang commented Oct 28, 2019

Is it solved? should we close it?

@rmontuoro
Copy link
Contributor Author

Active MPI barriers have been eliminated after introducing the updated HDF5 I/O layer in IPE.

One barrier still remain in the unused legacy subroutine Write_Electron_Density_to_HDF5 in IPE_Plasma_Class.F90.
Can we delete this legacy subroutine, or should it be updated to use the HDF5 I/O later?

@rmontuoro
Copy link
Contributor Author

Write_Electron_Density_to_HDF5() is not used in IPE and should be removed.

@rmontuoro rmontuoro transferred this issue from another repository Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants