Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figaro Division by Zero crash #8

Open
Patg13 opened this issue Aug 4, 2023 · 0 comments
Open

Figaro Division by Zero crash #8

Patg13 opened this issue Aug 4, 2023 · 0 comments
Labels
bug Something isn't working Long term dev For features/bugs/enhancement that will be done in the future

Comments

@Patg13
Copy link
Collaborator

Patg13 commented Aug 4, 2023

Some dataset cause a division by Zero error (ex: Copeaux ITS), this must be investigated to identify the problem

Dataset seems to have been pretrimmed, causing the sequences length to be shorter than normal, probably causing the bug. Will investigate a little more, but it's probably not a bug with Figaro itself.

EDIT:
The dataset was problematic because the longest sequence is way over the mean length, so when the offset is applied, the resulting trimming length is too high, which reject almost all reads in the dataset. I will not close this yet, because this point out a weakness in the Figaro trimming parameter definition (longest length - user-defined offset). A better way to determine the offset must be found.

Maybe wait for Figaro2 which should include a mechanism to fix this issue

@Patg13 Patg13 added bug Something isn't working Long term dev For features/bugs/enhancement that will be done in the future labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Long term dev For features/bugs/enhancement that will be done in the future
Projects
None yet
Development

No branches or pull requests

1 participant