Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Srping cleaning for parameters - get_key_def edition #479

Open
CharlesAuthier opened this issue Feb 14, 2023 · 0 comments
Open

Srping cleaning for parameters - get_key_def edition #479

CharlesAuthier opened this issue Feb 14, 2023 · 0 comments
Assignees

Comments

@CharlesAuthier
Copy link
Collaborator

After changing the get_key_def function, I notice some get_key_def function with the parameter to_path=True have also the parameter expected_type=str but with the new modification those one need to be change to expected_type=Path. Some of them like line 373 in inference segmentation or the line 366 of the same function are not flag in the test since their value are None, a option will be to raise a message if the parameter expected_type is not a path when to_path=True.

Also, a lot of change have been done recently, we need to take a look at all the parameters that are call but not use or dont have any value .

@CharlesAuthier CharlesAuthier self-assigned this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant