Update clang-format version

[jmarrec]

Issue overview

EnergyPlus/.github/workflows/test_code_integrity.yml

Lines 16 to 21 in acda84e

	- name: Run clang-format style check for C/C++ source code.
	uses: jidicula/clang-format-action@v4.14.0
	if: always()
	with:
	clang-format-version: '10'
	check-path: 'src/EnergyPlus'

clang-format-10 is no longer installable on Ubuntu 24.04 (the current LTS) which makes it quite annoying.

I can't seem to figure out a way to tweak the rules so that clang-format-18 for eg produces the same format as clang-format-10, in particular with respect to the way the trailing comments are aligned (AlignTrailingComments: true) when they are after closing braces and I've been looking for an hour.

Here's an example from ZoneTempPredictorCorrector.cc:

I would recommend picking a newer clang-format version, reformatting the entire codebase in one commit, and excluding it by adding it to .git-blame-ignore-revs.

Another diff is the way parameter packs are handled and attributes

IOFiles.hh parameter packs and spacing before braces in ctor

EPVector.hh attributes:

---

A couple of weird things can be found in the .clang-format config file too

EnergyPlus/src/.clang-format

Lines 1 to 2 in acda84e

	# Commented out lines are those which are not yet valid
	# in clang-3.8 which ships with Ubuntu

EnergyPlus/src/.clang-format

Line 24 in acda84e

Standard: Cpp11

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version): all
• Version of EnergyPlus (if using an intermediate build, include SHA): develop, acda84e

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to EnergyPlus Defect Complexity (Github Project)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[mjwitte]

A recent Visual Studio update has been applying these newer rules (like the comment alignment) already, so this will be helpful.

[jmarrec]

Since v17.9, MSVC 2022 ships with Clang 17, https://developercommunity.visualstudio.com/t/update-clang-format-to-latest-version/1291564#TPIN-N10630932.

With the latest MSVC, it's clang 18.

$ Load-DevTools 2022 -A x64
Found Visual Studio Community 2022 (VisualStudio/17.12.3+35527.113), latest updated on 2024-12-18
**********************************************************************
** Visual Studio 2022 Developer PowerShell v17.12.3
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
Dev environment variables set

$ clang-cl --version
clang version 18.1.8
Target: i686-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\Llvm\bin

The default, stable, branch on https://apt.llvm.org/ (for Ubuntu for eg) is 18

I would propose to update to clang-format 18 as a result. @Myoldmopar can I do that?