Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Allow actual 5% difference in heating/cooling fraction load served #70

Closed
bookwyrm opened this issue Apr 2, 2018 · 1 comment
Closed
Assignees

Comments

@bookwyrm
Copy link

bookwyrm commented Apr 2, 2018

When processing an HPXML file with FractionHeatLoadServed value of 0.95 and FractionCoolLoadServed value of 1.0 where the two systems share the same duct system, there is a translation error stating that the two values are not within 5% of each other.

This is likely due to an approximation of floating point values.

I suggest changing the boundary check from 0.05 to 0.051 at https://github.com/NREL/hescore-hpxml/blob/master/hescorehpxml/__init__.py#L1655 in order to allow an actual check of 5% threshold.

@nmerket nmerket self-assigned this Apr 4, 2018
@nmerket
Copy link
Member

nmerket commented Apr 4, 2018

Sounds reasonable to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants