Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case error in hospital bar #137

Closed
DavidGoldwasser opened this issue Sep 30, 2021 · 2 comments
Closed

Edge case error in hospital bar #137

DavidGoldwasser opened this issue Sep 30, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DavidGoldwasser
Copy link
Contributor

DavidGoldwasser commented Sep 30, 2021

While working on an intersection issue and adding new tests, I ran across case where bar for hospital has error. I'm investigating possible cause. One may be that expectation is that primary space type is also the largest space type, and in hospital that isn't the case. Primary is patient room but nurse station has more area, and logic of how bar is sliced may not account for that. Corridor is actually even larger than nurse station. I only hit issue when using dual bar, which combines patient room with corridor. I'd like to fix this and keep that pairing.

Here is the error

Hospital Corridor doesn't have the expected floor area (actual 5,175 ft^2, target 4,657 ft^2)
Hospital NurseStn doesn't have the expected floor area (actual 3,840 ft^2, target 4,609 ft^2)
Hospital PatRoom doesn't have the expected floor area (actual 2,512 ft^2, target 2,260 ft^2)
Sum of actual floor area is 22289.999999999964 ft^2, sum of target floor area is 22290.000000000004.

And here is the test it happens on
https://github.com/NREL/openstudio-extension-gem/blob/intersect_tests_072021/spec/openstudio/core/os_lib_model_generation_spec.rb#L650

@DavidGoldwasser DavidGoldwasser self-assigned this Sep 30, 2021
@DavidGoldwasser DavidGoldwasser added the bug Something isn't working label Sep 30, 2021
@DavidGoldwasser
Copy link
Contributor Author

I did confirm switching NurseStn to default in place of PatRoom got rid of the error in this case, but have not decide to go that direction yet. It still slightly smaller than corridor.

@DavidGoldwasser
Copy link
Contributor Author

Testing linking ClickUp task to this issue CU-1h1w54v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant