Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_lib_model_generation does not assign SWH type correctly #138

Closed
eringold opened this issue Oct 4, 2021 · 0 comments · Fixed by #139
Closed

os_lib_model_generation does not assign SWH type correctly #138

eringold opened this issue Oct 4, 2021 · 0 comments · Fixed by #139

Comments

@eringold
Copy link
Contributor

eringold commented Oct 4, 2021

# Infer the SWH type
if args['swh_src'] == 'Inferred'
if args['htg_src'] == 'NaturalGas' || args['htg_src'] == 'DistrictHeating'
args['swh_src'] = 'NaturalGas' # If building has gas service, probably uses natural gas for SWH
elsif args['htg_src'] == 'Electricity'
args['swh_src'] == 'Electricity' # If building is doing space heating with electricity, probably used for SWH
elsif args['htg_src'] == 'DistrictAmbient'
args['swh_src'] == 'HeatPump' # If building has district ambient loop, it is fancy and probably uses HPs for SWH
else
args['swh_src'] = nil # Use inferences built into OpenStudio Standards for each building and space type
end
end

Equality operator == used instead of assignment =:
Line 2963 should be
args['swh_src'] = 'Electricity' # If building is doing space heating with electricity, probably used for SWH
Line 2965 should be
args['swh_src'] = 'HeatPump' # If building has district ambient loop, it is fancy and probably uses HPs for SWH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant