Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charge $/day multiplied by the incorrect units #123

Closed
brtietz opened this issue Oct 26, 2022 · 4 comments · Fixed by #145
Closed

Fix charge $/day multiplied by the incorrect units #123

brtietz opened this issue Oct 26, 2022 · 4 comments · Fixed by #145
Labels
bug Something isn't working

Comments

@brtietz
Copy link
Collaborator

brtietz commented Oct 26, 2022

Units reported in $/day are multiplied by 365 / 30, leading a rate of $0.16/day to be computed as $1.99/month.

However, that is much less than just multiplying the value by 30. Suggest 365/12 as a better multiplier.
@brtietz brtietz added the bug Something isn't working label Oct 26, 2022
@dguittet
Copy link
Collaborator

What pysam code is doing this?

@brtietz
Copy link
Collaborator Author

brtietz commented Oct 26, 2022

SAM doesn't support $/day units, so in the GUI an lk script handles the conversion, and resource tools handles it here.

@brtietz
Copy link
Collaborator Author

brtietz commented Oct 26, 2022

Fixed in #124

@brtietz brtietz closed this as completed Oct 26, 2022
@brtietz
Copy link
Collaborator Author

brtietz commented Apr 3, 2023

It looks like due to some copy-paste errors, this isn't fixed in the URDB V8 script, and minimum charges also need to be fixed.

@brtietz brtietz reopened this Apr 3, 2023
@brtietz brtietz mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply $/day units fix to minimum charges and URDB v8 script NREL/pysam
2 participants
@brtietz @dguittet