Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODS bootstrapping returns None when soiling signal is small #396

Closed
martin-springer opened this issue Oct 17, 2023 · 1 comment
Closed
Assignees

Comments

@martin-springer
Copy link
Collaborator

Describe the bug
CODS - run_bootstrap returns None when 'Soiling signal is small relative to the noise.' The error message is printed but an exception is not raised. In a successful run, three arguments are returned. In the case of a small soiling signal only one argument (None) is returned, which causes an exception when three arguments are expected from the function as is the case in the tutorial example results_df, degradation, soiling_loss = CODS.run_bootstrap(reps=16, verbose=True).

Here is a link to the return statement that causes the exception:

return

Full error message and traceback
TypeError: cannot unpack non-iterable NoneType object

To Reproduce
Run CODS bootstrapping on: 5169 | ac_power_inv_2831 with
result_df, degradation, soiling_loss = CODS.run_bootstrap(**params_CODS)

Expected behavior
Raise exception instead of printing error or return the correct number of arguments.

@martin-springer martin-springer self-assigned this Nov 9, 2023
@martin-springer
Copy link
Collaborator Author

Closing as duplicate of #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant