Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential errors in ALiPy/examples/AL_settings/query_instance.py? #24

Open
PingjieTang opened this issue Nov 22, 2019 · 2 comments
Open

Comments

@PingjieTang
Copy link

PingjieTang commented Nov 22, 2019

Thanks so much for the awesome library!
I was trying to run the "query_instance.py", the only changes I made to the code are:
i) Increased the num_of_queries from 50 to 500
ii) I set the number of rounds (probably "folds" is the word that you would like to use) to 1
I only tried QBC and random methods, and you will find the plot from the attached.
alipy_plotting
It is observable that QBC does not outperform random, both are performing alike on the simulated data. Any thoughts on it?

@Lggggggx
Copy link
Collaborator

The main reason may be that the simulated data created by sklearn.make_classification is too simple. The default Logistic Regression classifier can easily fit. And there may be a lot of samples that is similar. It would be useless to add the similar samples after the one has been learned by the model.
And the results of a single experiment may be random. The results are more convincing if the number of experiments(round) is set as a large value.

There is no guarantee that the QBC is must better than Random in any case. The QBC is generally better.

@PingjieTang
Copy link
Author

Thanks for the quick response, which generally addressed my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants