Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] getting-started-movielens use of local disk in unintended ways #162

Closed
mattf opened this issue Mar 25, 2022 · 2 comments · Fixed by #166
Closed

[BUG] getting-started-movielens use of local disk in unintended ways #162

mattf opened this issue Mar 25, 2022 · 2 comments · Fixed by #166
Labels
documentation Improvements or additions to documentation

Comments

@mattf
Copy link

mattf commented Mar 25, 2022

https://github.com/NVIDIA-Merlin/Merlin/blob/main/examples/getting-started-movielens/03-Training-with-HugeCTR.ipynb

MODEL_DIR = os.path.join(INPUT_DATA_DIR, "model/movielens_hugectr/")
!rm -r MODEL_DIR
!mkdir MODEL_DIR + "1"

this code does not rm -r .../model/movielens_hugectr and create .../model/movielens_hugectr/1. it removes MODEL_DIR and creates MODEL_DIR, +, and 1.

code to achieve the intended outcome is more like the following (-p needed because of nesting)

os.environ.putenv('MODEL_DIR', os.path.join(INPUT_DATA_DIR, "model/movielens_hugectr/"))
!rm -r $MODEL_DIR
!mkdir -p ${MODEL_DIR} + "1"

this error persists across example notebooks

@karlhigley
Copy link
Contributor

karlhigley commented Mar 25, 2022

Good catch! Could you open a PR to fix that @mattf?

EDIT: Actually, this has also already been addressed in the NVTabular version of these notebooks. I think these notebooks have just gotten a bit out of date.

@karlhigley karlhigley added the documentation Improvements or additions to documentation label Mar 25, 2022
@mattf
Copy link
Author

mattf commented Mar 26, 2022

i'm happy to after #165 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants