-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate CMake installs #523
Conversation
CMake is now installed in the Merlin base container that these images for TF and HugeCTR are based on, so we don't need to install it again.
Documentation preview |
Click to view CI ResultsGitHub pull request #523 of commit 3464b56b1bab0db44ed86d0d5d33ecce6315822a, no merge conflicts. Running as SYSTEM Setting status of 3464b56b1bab0db44ed86d0d5d33ecce6315822a to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/328/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/523/*:refs/remotes/origin/pr/523/* # timeout=10 > git rev-parse 3464b56b1bab0db44ed86d0d5d33ecce6315822a^{commit} # timeout=10 Checking out Revision 3464b56b1bab0db44ed86d0d5d33ecce6315822a (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 3464b56b1bab0db44ed86d0d5d33ecce6315822a # timeout=10 Commit message: "Remove duplicate CMake installs" > git rev-list --no-walk 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins6201319646499698583.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #523 of commit b6428a64899c9abd85a0a1ed047b2fe33079fe39, no merge conflicts. Running as SYSTEM Setting status of b6428a64899c9abd85a0a1ed047b2fe33079fe39 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/329/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/523/*:refs/remotes/origin/pr/523/* # timeout=10 > git rev-parse b6428a64899c9abd85a0a1ed047b2fe33079fe39^{commit} # timeout=10 Checking out Revision b6428a64899c9abd85a0a1ed047b2fe33079fe39 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f b6428a64899c9abd85a0a1ed047b2fe33079fe39 # timeout=10 Commit message: "Copy CMake from the build image to the base image" > git rev-list --no-walk 3464b56b1bab0db44ed86d0d5d33ecce6315822a # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins4429448119077131763.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #523 of commit 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca, no merge conflicts. Running as SYSTEM Setting status of 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/330/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/523/*:refs/remotes/origin/pr/523/* # timeout=10 > git rev-parse 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca^{commit} # timeout=10 Checking out Revision 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca # timeout=10 Commit message: "Add Ninja build system to base image" > git rev-list --no-walk b6428a64899c9abd85a0a1ed047b2fe33079fe39 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins2237833679868984891.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #523 of commit 829a495f8ece5ecf14b891fdfed41a861a3d6433, no merge conflicts. Running as SYSTEM Setting status of 829a495f8ece5ecf14b891fdfed41a861a3d6433 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/331/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/523/*:refs/remotes/origin/pr/523/* # timeout=10 > git rev-parse 829a495f8ece5ecf14b891fdfed41a861a3d6433^{commit} # timeout=10 Checking out Revision 829a495f8ece5ecf14b891fdfed41a861a3d6433 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 829a495f8ece5ecf14b891fdfed41a861a3d6433 # timeout=10 Commit message: "Use `make -j$(nproc)` consistently to parallelize builds" > git rev-list --no-walk 3ae921bea2d0f1cbddfb5f57228a3202e2ce1bca # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins11907752253286421143.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
This reverts commit cf83cb3.
CMake is now installed in the Merlin base container that these images for TF and HugeCTR are based on, so we don't need to install it again.