Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Masking shouldn't be used for test data #391

Open
sararb opened this issue Apr 22, 2022 · 2 comments
Open

[TASK] Masking shouldn't be used for test data #391

sararb opened this issue Apr 22, 2022 · 2 comments
Labels
area/research area/session-based P1

Comments

@sararb
Copy link
Contributor

sararb commented Apr 22, 2022 •
edited
Loading

Masking class: sequences are shifted to keep the last item as a label during evaluation (Training=False) but we should disable masking and keep the sequence as it is for the Test data
@sararb sararb assigned sararb and unassigned sararb Apr 22, 2022
@rnyak
Copy link
Contributor

rnyak commented Oct 3, 2022

@sararb added ignore_masking flag in the TF4Rec to avoid this issue.

@rnyak rnyak changed the title [BUG] Masking shouldn't be used for test data [TASK] Masking shouldn't be used for test data Oct 3, 2022
@rnyak
Copy link
Contributor

rnyak commented Oct 3, 2022

Relevant PRs:
#780
#775

@sararb sararb added area/session-based and removed bug Something isn't working labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/research area/session-based P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rnyak @sararb @viswa-nvidia