Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Allow for pre-filtering of features a branch needs in a ParallelBlock #674

Closed
marcromeyn opened this issue Aug 24, 2022 · 0 comments · Fixed by #686
Closed

[Task] Allow for pre-filtering of features a branch needs in a ParallelBlock #674

marcromeyn opened this issue Aug 24, 2022 · 0 comments · Fixed by #686
Assignees
Milestone

Comments

@marcromeyn
Copy link
Contributor

Description

Right now inside a ParallelBlock, we broadcast it’s inputs to all the branches. Each branch then filters the features it needs. This leads to some unexpected behaviour when you try to save a branch to be served since the resulting TF-model will expect all features.

This shows up for instance inside a TwoTowerModel where we would like to serve the query-tower, we currently have a hacky workaround that does the pre-filtering in that case (source). We would like to create a more general solution.

Additional context
Proposal, have a flag pre_filter_features=True to the ParallelBlock. Inside the call-method we would check for each branch if it contains a schema-param. If so, we do the pre-filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants