Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Extract unrolling logic out of Aggregation into Unroll & make it mask-aware #713

Closed
marcromeyn opened this issue Sep 5, 2022 · 0 comments · Fixed by #737
Closed
Assignees
Milestone

Comments

@marcromeyn
Copy link
Contributor

marcromeyn commented Sep 5, 2022

In a session-based recsys setting, you often have contextual-features (1-D features like time-of-day, device-type, etc.) & session features (2-D features, a feature per timestep of the sequence). We typically merge these features by unrolling the 1-D features into the shape of the session-features:

CleanShot 2022-09-05 at 10 42 08

This logic is now part of the aggregations (here to be specific). We would like to break this out into a new class (working name Unroll).

One reason for this is that we want to make use of the standard way in Keras to propagate masks (more info can be found here). This new class should implemtent compute_mask in order to alter the masks (it should add the mask info for all the contextual features).

@marcromeyn marcromeyn transferred this issue from NVIDIA-Merlin/Merlin Sep 5, 2022
@marcromeyn marcromeyn changed the title Extract unrolling logic out of Aggregation into Unroll & make it mask-aware [TASK] Extract unrolling logic out of Aggregation into Unroll & make it mask-aware Sep 5, 2022
@marcromeyn marcromeyn added this to the Merlin 22.09 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants