Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Create a post block to be able to feed continuous list features to an MLP model #960

Closed
rnyak opened this issue Jan 25, 2023 · 1 comment · Fixed by #969
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request P0
Milestone

Comments

@rnyak
Copy link
Contributor

rnyak commented Jan 25, 2023

Description

Currently, we are not able to feed continuous list features to an MLP model since the aggregation of this list features are not working as expected. We tested the following in the InputBlockV2 as continuous arg, but it does not work:

        continuous=mm.ContinuousFeatures.from_schema(schema_model.select_by_name(['length_of_stay_list']), 
                                                                           post=SequenceAggregator(SequenceAggregation.MEAN),
                                                                           aggregation='concat')

if we can make SequenceAggregator work for this case, that'd be solving the issue. It does not work now, since right now it has hard requirement that the input should be 3D. it should be able to work with 2D tensor as well.

This is an important feature for GTC'23 Merlin tutorial.

@rnyak rnyak added bug Something isn't working enhancement New feature or request P0 labels Jan 25, 2023
@rnyak rnyak added this to the Merlin 23.02 milestone Jan 25, 2023
@rnyak rnyak changed the title [Task] Create a post block to be able to feed continuous list features to an MLP model [FEA] Create a post block to be able to feed continuous list features to an MLP model Jan 27, 2023
@rnyak
Copy link
Contributor Author

rnyak commented Feb 6, 2023

fixed by #969

@rnyak rnyak closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request P0
Projects
None yet
2 participants