fix(config): correct dialog rails activation logic (#1161)

* fix(config): correct dialog rails activation logic

Fixed the `has_dialog_rails` logic in `RailsConfig` to require both
`user_messages` and `bot_messages` for implicit activation. Removed
`flows` from the condition to align with expected behavior.

test(config): adjust tests for updated dialog rails logic

Modified test cases to reflect the corrected dialog rails activation
logic.

* Update tests/test_config_validation.py based on reveiw

Author: Pouyanpi

nemoguardrails/rails/llm/config.py

@@ -1203,11 +1203,10 @@ def check_reasoning_traces_with_dialog_rails(cls, values):
         ]
 
         # dialog rails are activated (explicitly or implicitly)
-        has_dialog_rails = (
-            bool(dialog_rails)
-            or bool(values.get("user_messages"))
-            or bool(values.get("bot_messages"))
-            or bool(values.get("flows"))
+        has_dialog_rails = bool(dialog_rails) or (
+            bool(values.get("user_messages"))
+            and bool(values.get("bot_messages"))
+            # and bool(values.get("flows"))
         )
 
         if has_dialog_rails:

tests/test_config_validation.py

@@ -295,6 +295,10 @@ def test_reasoning_traces_with_implicit_dialog_rails_flows_only():
             define flow
               user express greeting
               bot express greeting
+            define user express greeting
+                "hi"
+            define bot express greeting
+                "HI HI"
             """,
         )
 
@@ -311,65 +315,41 @@ def test_reasoning_traces_with_implicit_dialog_rails_flows_only():
 
 
 def test_reasoning_traces_with_implicit_dialog_rails_user_messages_only():
-    """Test that reasoning traces cannot be enabled when dialog rails are implicitly enabled thru user messages only."""
+    """Test that reasoning traces cannot be enabled when dialog rails are implicitly enabled through user messages (user canonical forms) only."""
 
-    with pytest.raises(ValueError) as exc_info:
-        _ = RailsConfig.from_content(
-            yaml_content="""
-            models:
-              - type: main
-                engine: openai
-                model: gpt-3.5-turbo-instruct
-                reasoning_config:
-                  remove_thinking_traces: false
-            """,
-            colang_content="""
+    _ = RailsConfig.from_content(
+        yaml_content="""
+        models:
+        - type: main
+          engine: openai
+          model: gpt-3.5-turbo-instruct
+          reasoning_config:
+              remove_thinking_traces: false
+        """,
+        colang_content="""
             define user express greeting
               "hello"
               "hi"
-            """,
-        )
-
-    assert "Main model has reasoning traces enabled in config.yml" in str(
-        exc_info.value
-    )
-    assert "Reasoning traces must be disabled when dialog rails are present" in str(
-        exc_info.value
-    )
-    assert (
-        "Please update your config.yml to set 'remove_thinking_traces: true' under reasoning_config"
-        in str(exc_info.value)
+        """,
     )
 
 
-def test_reasoning_traces_with_implicit_dialog_rails_bot_messages_only():
-    """Test that reasoning traces cannot be enabled when dialog rails are implicitly enabled thru bot messages only."""
+def test_reasoning_traces_with_bot_messages_only():
+    """Test that reasoning traces can exist with bot messages only."""
 
-    with pytest.raises(ValueError) as exc_info:
-        _ = RailsConfig.from_content(
-            yaml_content="""
-            models:
-              - type: main
-                engine: openai
-                model: gpt-3.5-turbo-instruct
-                reasoning_config:
-                  remove_thinking_traces: false
-            """,
-            colang_content="""
-            define bot express greeting
-              "Hello there!"
-            """,
-        )
-
-    assert "Main model has reasoning traces enabled in config.yml" in str(
-        exc_info.value
-    )
-    assert "Reasoning traces must be disabled when dialog rails are present" in str(
-        exc_info.value
-    )
-    assert (
-        "Please update your config.yml to set 'remove_thinking_traces: true' under reasoning_config"
-        in str(exc_info.value)
+    _ = RailsConfig.from_content(
+        yaml_content="""
+        models:
+        - type: main
+          engine: openai
+          model: gpt-3.5-turbo-instruct
+          reasoning_config:
+              remove_thinking_traces: False
+        """,
+        colang_content="""
+        define bot express greeting
+            "Hello there!"
+        """,
     )