Skip to content

Commit cccc62f

Browse files
committed
Fix: Address feedback for safe_eval function
1 parent c2f4ef8 commit cccc62f

File tree

2 files changed

+26
-43
lines changed

2 files changed

+26
-43
lines changed

tests/test_generate_value_safe_eval.py

Lines changed: 0 additions & 42 deletions
This file was deleted.

tests/test_utils.py

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import pytest
1717

18-
from nemoguardrails.utils import new_event_dict
18+
from nemoguardrails.utils import new_event_dict, safe_eval
1919

2020

2121
def test_event_generation():
@@ -119,3 +119,28 @@ def test_wrong_property_type():
119119
event_type,
120120
script=script,
121121
)
122+
123+
124+
@pytest.mark.parametrize(
125+
"input_value, expected_result",
126+
[
127+
('"It\'s a sunny day"', "It's a sunny day"), # double quotes with single quote
128+
(
129+
"\"He said, 'Hello'\"",
130+
"He said, 'Hello'",
131+
), # double quotes with nested single quote
132+
(
133+
"It's a sunny day",
134+
"It's a sunny day",
135+
), # unquoted string containing single quote
136+
(
137+
"It is a sunny day",
138+
"It is a sunny day",
139+
), # plain string not wrapped in quotes
140+
("", ""), # empty string
141+
],
142+
)
143+
def test_safe_eval(input_value, expected_result):
144+
"""Test safe_eval with various input values."""
145+
result = safe_eval(input_value)
146+
assert result == expected_result

0 commit comments

Comments
 (0)