Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile when targeting aarch64-apple-darwin #107

Closed
Jake-Shadle opened this issue Mar 2, 2023 · 1 comment
Closed

Doesn't compile when targeting aarch64-apple-darwin #107

Jake-Shadle opened this issue Mar 2, 2023 · 1 comment

Comments

@Jake-Shadle
Copy link

Library and Version

5.1.3

Operating System

aarch64-apple-darwin

Steps to Trigger Behavior

  1. Try to compile for aarch64-apple-darwin
  2. Failure

Code Snippet to Reproduce Behavior

Irrelevant

Expected Behavior

PhysX compiles

Actual Behavior

PhysX fails to compile for several reasons:

  1. FdUnixFPU.cpp includes <xmmintrin.h> if PX_OSX is 1, which fails since that is an x86 only header. See EmbarkStudios@1e04de1 for a commit to fix this
  2. SIMD is not properly enabled in PxVecMath.h, causing failures in other code that doesn't have the same guard. See EmbarkStudios@33e5eb7 for a commit to fix this.
  3. SnSerialUtils.cpp fails to compile due to no case matching aarch64 and OSX, resulting in Unknown binary platform. See EmbarkStudios@720c8a5 for a patch to fix this.

FYI, the only reason that PhysX 4.1 compiled for aarch64-apple-darwin was because it misidentified the target to PX_IOS

https://github.com/NVIDIAGameWorks/PhysX/blob/a2c0428acab643e60618c681b501e86f7fd558cc/pxshared/include/foundation/PxPreprocessor.h#L103-L106

But it appears like iOS support has been completely dropped in PhysX 5 (with no CHANGELOG entry) resulting in these errors.

@preist-nvidia
Copy link
Collaborator

Hi @Jake-Shadle - we are not supporting this build platform, but you may contribute/find support for it on the community-maintained build config fork: https://github.com/NVIDIA-Omniverse/PhysX#community-maintained-build-configuration-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants