Skip to content

Conversation

@NJ-186
Copy link
Contributor

@NJ-186 NJ-186 commented Dec 2, 2024

Description

This PR aims to resolve "Incomplete URL substring sanitization" Error thrown by CodeQL.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@Pouyanpi Pouyanpi self-requested a review December 3, 2024 06:08
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NJ-186, it looks good to me!

@Pouyanpi
Copy link
Collaborator

Pouyanpi commented Dec 3, 2024

@NJ-186 Just make sure that all your commits are signed, please refer to contributing docs. Then we can merge

@NJ-186 NJ-186 force-pushed the fix/privateai-url-parsing branch from 44b9ccc to 1f71e42 Compare December 3, 2024 13:31
@NJ-186
Copy link
Contributor Author

NJ-186 commented Dec 3, 2024

@NJ-186 Just make sure that all your commits are signed, please refer to contributing docs. Then we can merge

@Pouyanpi Thanks for the review! I have updated my commits with the signature.

@Pouyanpi Pouyanpi merged commit ef22f22 into NVIDIA-NeMo:develop Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants