Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import FastPitchModel fails with unrelated error from prompth_encoder.py #7238

Closed
bene-ges opened this issue Aug 15, 2023 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@bene-ges
Copy link
Contributor

Describe the bug

Running tutorials/tts/FastPitch_Finetuning.ipynb on Colab get error on import FastPitchModel

Steps/Code to reproduce bug

[/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/modules/common/prompt_encoder.py](https://localhost:8080/#) in TPMLP()
    138     def __init__(
    139         self,
--> 140         config: ModelParallelConfig,
    141         total_virtual_tokens: int,
    142         hidden_size: int,

NameError: name 'ModelParallelConfig' is not defined
@bene-ges bene-ges added the bug Something isn't working label Aug 15, 2023
@jeremiecoullon
Copy link

Hello!

The same error happens if I run the google colab for the NeMo forced aligner.

Steps to reproduce:

Run the google colab until part 3 ("Run NFA"). The first code cell (!python $NEMO_DIR_PATH/tools/nemo..etc..) returns NameError: name 'ModelParallelConfig' is not defined

@rlangman
Copy link
Collaborator

rlangman commented Aug 16, 2023

A lot of scripts are broken at the moment because of a commit involving Megatron https://github.com/NVIDIA/NeMo/commit/4833347105b5ec8526ae182cd2e1011b091ea89d

Until issues with this are resolved, I suggest using the commit before that one, like https://github.com/NVIDIA/NeMo/commit/f4afdf07ad742bdb2f45135f05d5d7dd8270eb51

For example if pip installing:

python -m pip install git+https://github.com/NVIDIA/NeMo.git@f4afdf07ad742bdb2f45135f05d5d7dd8270eb51#egg=nemo_toolkit[all]

@erastorgueva-nv
Copy link
Collaborator

Hi @bene-ges and @jeremiecoullon, thanks for bringing this to our attention.
This issue has now been fixed in the #7254 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants