Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an interface similar to OpenAI API #334

Open
Pevernow opened this issue Nov 9, 2023 · 19 comments
Open

Provide an interface similar to OpenAI API #334

Pevernow opened this issue Nov 9, 2023 · 19 comments
Assignees
Labels
feature request New feature or request triaged Issue has been triaged by maintainers

Comments

@Pevernow
Copy link

Pevernow commented Nov 9, 2023

Could you please provide a simple interface similar to OpenAI API?

@juney-nvidia
Copy link
Collaborator

@Pevernow
Can you elaborate more about your request?
Thanks
June

@juney-nvidia juney-nvidia self-assigned this Nov 9, 2023
@juney-nvidia juney-nvidia added the triaged Issue has been triaged by maintainers label Nov 9, 2023
@Pevernow
Copy link
Author

image
The most basic thing is just a simple chat/completions function similar to OpenAI.

The purpose is to facilitate access to existing applications that use the chatgpt API.

Currently, many open-source LLM projects have implemented this feature, such as the famous oobabooga/text generation webui

@merrymercy
Copy link

merrymercy commented Nov 11, 2023

Users want something like this https://github.com/lm-sys/FastChat/blob/main/docs/openai_api.md, so they can switch their apps from OpenAI models to TRT-LLM models easily without code change.

@Pevernow
Copy link
Author

@juney-nvidia Please take a look here, thank you

@gesanqiu
Copy link

gesanqiu commented Nov 15, 2023

Right now Python API still have a lot of issues to be fixed, I encapsulated one OpenAI API, but met #283, so you still need use C++ runtime, which means you need Triton. Spent weeks on TRT-LLM, it difficult to develop on python runtime.

@juney-nvidia What's the position of TRT-LLM's Python runime? I mean, python is easier than C++, and batch manager doesn't open source right now. Most developors may not use Triton since they won't meet that large commercial demand.

@chrjxj
Copy link

chrjxj commented Nov 27, 2023

mark

@juney-nvidia
Copy link
Collaborator

juney-nvidia commented Dec 11, 2023

Sorry for replying late due to being trapped by other things.

Users want something like this https://github.com/lm-sys/FastChat/blob/main/docs/openai_api.md, so they can switch their apps from OpenAI models to TRT-LLM models easily without code change.

@Pevernow @merrymercy well received, will discuss with prod about this. @ncomly-nvidia for vis.

What's the position of TRT-LLM's Python runime? I mean, python is easier than C++, and batch manager doesn't open source right now. Most developors may not use Triton since they won't meet that large commercial demand.

@gesanqiu we have already released the Python binding of C++ runtime, including batch manager, does this fulfill your requirement here?

@juney-nvidia juney-nvidia added feature request New feature or request and removed triaged Issue has been triaged by maintainers labels Dec 11, 2023
@ncomly-nvidia ncomly-nvidia added the triaged Issue has been triaged by maintainers label Dec 11, 2023
@binarycrayon
Copy link

vote up, monitoring

@binarycrayon
Copy link

More info about openai chat completion API spec here
https://github.com/openai/openai-openapi/tree/master

@whk6688
Copy link

whk6688 commented Mar 12, 2024

i need it too

@LMarino1
Copy link

+1 for OpenAI API support

1 similar comment
@Mary-Sam
Copy link

Mary-Sam commented Jun 8, 2024

+1 for OpenAI API support

@mynameiskeen
Copy link

+1 for OpenAI API support, it's been 9 months since the pr requested :(

@palindsay
Copy link

+1 OpenApi support

@nstl-zyb
Copy link

+1

@wertyac
Copy link

wertyac commented Aug 1, 2024

+1 for openai api support。

@Alireza3242
Copy link

+1 for openai api support

1 similar comment
@mohankrishna225
Copy link

+1 for openai api support

@viningz
Copy link

viningz commented Sep 9, 2024

+1 for openai api support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests