[PyTorch] Bugfix for wgrad bulk overlap conflict when dgrad overlap is reduce-scatter #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Userbuffers config dictionary sets overlap method to
ring-exchange
orpipeline
for any*_dgrad
layer, that layer's*_wgrad
overlap needs to be disabled in order forub_overlap_rs_dgrad=True
option for related TE modules to function correctly.This PR fixes a bug where the "*_wgrad" overlap was persisting in the Userbuffer configuration and the corresponding UB object was being initialized even when it was not needed.
Type of change
Changes
Please list the changes introduced in this PR:
*_wgrad
overlap is now removed frommethods["bulk"]
list when the same layer's*_dgrad
overlap has its method set to eitherring-exchange
orpipeline
.add_ub(name, **ub_cfg)
is now only called ifname
is in the original user-providedub_cfg
. This avoids creating UB objects with default configs that may conflict with the user's intended TP overlap use.Checklist: