Apply feedback from elstehle

bernhardmgruber · bernhardmgruber · commit 005411b8fb23 · 2025-03-04T10:49:13.000+01:00
diff --git a/cub/benchmarks/bench/scan/exclusive/by_key.cu b/cub/benchmarks/bench/scan/exclusive/by_key.cu
@@ -84,7 +84,7 @@ static void scan(nvbench::state& state, nvbench::type_list<KeyT, ValueT, OffsetT
   using val_input_it_t  = const ValueT*;
   using val_output_it_t = ValueT*;
   using equality_op_t   = ::cuda::std::equal_to<>;
-  using offset_t        = ::cuda::std::make_unsigned_t<OffsetT>;
+  using offset_t        = cub::detail::choose_offset_t<OffsetT>;
 
 #if !TUNE_BASE
   using policy_t   = policy_hub_t;
diff --git a/cub/cub/device/dispatch/dispatch_scan.cuh b/cub/cub/device/dispatch/dispatch_scan.cuh
@@ -165,7 +165,8 @@ template <
   typename KernelLauncherFactory = detail::TripleChevronFactory>
 struct DispatchScan
 {
-  static_assert(::cuda::std::is_unsigned_v<OffsetT>, "DispatchScan only supports unsigned offset types");
+  static_assert(::cuda::std::is_unsigned_v<OffsetT> && sizeof(OffsetT) >= 4,
+                "DispatchScan only supports unsigned offset types of at least 4-bytes");
 
   //---------------------------------------------------------------------
   // Constants and Types

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,8 @@ template <`
`165`	`165`	`typename KernelLauncherFactory = detail::TripleChevronFactory>`
`166`	`166`	`struct DispatchScan`
`167`	`167`	`{`
`168`		`- static_assert(::cuda::std::is_unsigned_v<OffsetT>, "DispatchScan only supports unsigned offset types");`
	`168`	`+ static_assert(::cuda::std::is_unsigned_v<OffsetT> && sizeof(OffsetT) >= 4,`
	`169`	`+ "DispatchScan only supports unsigned offset types of at least 4-bytes");`
`169`	`170`
`170`	`171`	`//---------------------------------------------------------------------`
`171`	`172`	`// Constants and Types`