Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asserts within library code should be opt-in not opt-out #969

Open
JAppleyard opened this issue Mar 4, 2021 · 0 comments
Open

asserts within library code should be opt-in not opt-out #969

JAppleyard opened this issue Mar 4, 2021 · 0 comments
Labels
libcu++ For all items related to libcu++

Comments

@JAppleyard
Copy link

assert within device code is relatively expensive. While users can opt-in to disabling asserts by defining NDEBUG optimzied builds should not have to define this to get performant library code.

This would mirror libc++ which requires an opt-in: https://libcxx.llvm.org/docs/DesignDocs/DebugMode.html#id2
@JAppleyard JAppleyard changed the title asserts should be opt-in not opt-out asserts within library code should be opt-in not opt-out Mar 4, 2021
@jrhemstad jrhemstad added the libcu++ For all items related to libcu++ label Feb 22, 2023
@jrhemstad jrhemstad mentioned this issue Jun 23, 2023
Merged
@jarmak-nv jarmak-nv transferred this issue from NVIDIA/libcudacxx Nov 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 8, 2023
@miscco miscco removed their assignment Dec 6, 2023
@bernhardmgruber bernhardmgruber mentioned this issue Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libcu++ For all items related to libcu++
Projects
CCCL
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miscco @JAppleyard @jrhemstad