Skip to content

Specify hard header dependencies in setup.py and fail build early if those headers are missing #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vzhurba01 opened this issue Dec 9, 2024 · 0 comments · Fixed by #514
Assignees
Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Comments

@vzhurba01
Copy link
Collaborator

Some headers are a hard dependency for which we know the compilation will fail like:

  • cuda.h
  • cudaProfiler.h
  • nvrtc.h
  • etc.

While others are option like:

  • cudaEGL.h
  • etc.

Currently the build gives a warning when certain headers are missing. If the mandatory header is missing then we fail at compile time. This can be improved by failing earlier when we first detect the mandatory header is missing. This will also allow for a cleaner error messaging.

@vzhurba01 vzhurba01 added cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do triage Needs the team's attention labels Dec 9, 2024
@leofang leofang removed the triage Needs the team's attention label Dec 13, 2024
@leofang leofang added this to the cuda-bindings parking lot milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants