Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VulkanBaseApp.cpp is using std::numeric_limits but not including <limits> #165

Open
Dryn opened this issue Nov 11, 2022 · 1 comment
Open

VulkanBaseApp.cpp is using std::numeric_limits but not including <limits> #165

Dryn opened this issue Nov 11, 2022 · 1 comment

Comments

@Dryn
Copy link

Dryn commented Nov 11, 2022 •
edited
Loading

Lines 696, 1691 and 1695 of VulkanBaseApp.cpp in the simpleVulkanMMap sample are using std::numeric_limits in VulkanBaseApp.cpp but #include <limits> isn't added to correctly reference.

Please add #include <limits> in the beginning.

Anologue for the simpleVulkan sample.
@atinfinity
Copy link

@Dryn I encountered same problem. And, I found this PR(#135) to resolve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dryn @atinfinity