Commit 0ac70df
authored
build pure-Python wheels without waiting for dependencies (#409)
Looking closely at the CI dependency graphs while working on #122, I noticed some opportunities to improve the end-to-end time for PR CI and nightly builds.
`wheel-build-{libB}` jobs only need to wait for `wheel-build-{libA}` jobs to complete if **building** `libB` wheels requires `libA`. This updates job dependencies here to follow that rule.
* `wheel-build-cuopt-server`: start building immediately
* `wheel-build-cuopt-sh-client`: start building immediately
* `build-images`: adds `wheel-build-cupot-sh-client` to jobs this needs to wait for (branch / nightly builds only)
- https://github.com/NVIDIA/cuopt/blob/933d810e517567f4b5cb3cd507b350eb30457a70/ci/docker/Dockerfile#L65
This PR also remove some unnecessary builds. This project is currently running 16 `wheel-build-cuopt-server` jobs (2 CUDA major x 2 CPU architectures x 4 Python versions) when it only needs 2 (1 per CUDA major version), because it publishes `py3-none-any` wheels (https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/cuopt-server-cu13).
* removes duplicate `cuopt-server` builds
* fixes artifact downloads of `cuopt-sh-client` in nightly tests
## Issue
Noticed while working towards #122
## Notes for Reviewers
### Benefits of these changes
Reduced end-to-end time for PR builds and probably for branch/nightly builds.
Reduced risk of failed or incorrect container-image builds resulting from `build-images` starting before there are `cuopt-sh-client` packages available.
14 fewer `wheel-build-cuopt-server` jobs per PR 😁
#
Authors:
- James Lamb (https://github.com/jameslamb)
Approvers:
- Ramakrishnap (https://github.com/rgsl888prabhu)
URL: #4091 parent 67d5151 commit 0ac70df
File tree
4 files changed
+16
-8
lines changed- .github/workflows
- ci
4 files changed
+16
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | | - | |
152 | 151 | | |
153 | 152 | | |
154 | 153 | | |
| |||
159 | 158 | | |
160 | 159 | | |
161 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
162 | 164 | | |
163 | 165 | | |
164 | 166 | | |
| |||
186 | 188 | | |
187 | 189 | | |
188 | 190 | | |
189 | | - | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
| |||
198 | 199 | | |
199 | 200 | | |
200 | 201 | | |
| 202 | + | |
201 | 203 | | |
202 | 204 | | |
203 | 205 | | |
| |||
212 | 214 | | |
213 | 215 | | |
214 | 216 | | |
215 | | - | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
216 | 221 | | |
217 | 222 | | |
218 | 223 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
209 | 212 | | |
210 | 213 | | |
211 | 214 | | |
| |||
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
222 | | - | |
| 225 | + | |
223 | 226 | | |
224 | 227 | | |
225 | 228 | | |
226 | 229 | | |
227 | 230 | | |
228 | 231 | | |
229 | 232 | | |
230 | | - | |
| 233 | + | |
231 | 234 | | |
232 | 235 | | |
233 | 236 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
0 commit comments