Skip to content

Fix issue with barrier incorrectly returning numerical in concurrent #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Oct 12, 2025
Merged

Fix issue with barrier incorrectly returning numerical in concurrent #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cpp/src/dual_simplex/barrier.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3266,14 +3266,15 @@ lp_status_t barrier_solver_t<i_t, f_t>::solve(f_t start_time,
}

iteration_data_t<i_t, f_t> data(lp, num_upper_bounds, settings);
if (data.symbolic_status != 0) {
settings.log.printf("Error in symbolic analysis\n");
return lp_status_t::NUMERICAL_ISSUES;
}
if (settings.concurrent_halt != nullptr && *settings.concurrent_halt == 1) {
settings.log.printf("Barrier solver halted\n");
return lp_status_t::CONCURRENT_LIMIT;
}
if (data.symbolic_status != 0) {
settings.log.printf("Error in symbolic analysis\n");
return lp_status_t::NUMERICAL_ISSUES;
}

data.cusparse_dual_residual_ = data.cusparse_view_.create_vector(data.d_dual_residual_);
data.cusparse_r1_ = data.cusparse_view_.create_vector(data.d_r1_);
data.cusparse_tmp4_ = data.cusparse_view_.create_vector(data.d_tmp4_);
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/mip/diversity/diversity_manager.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ bool diversity_manager_t<i_t, f_t>::run_presolve(f_t time_limit)
lp_dual_optimal_solution.resize(problem_ptr->n_constraints,
problem_ptr->handle_ptr->get_stream());
problem_ptr->handle_ptr->sync_stream();
CUOPT_LOG_INFO("After trivial presolve #constraints %d #variables %d objective offset %f.",
CUOPT_LOG_INFO("After trivial presolve: %d constraints, %d variables, objective offset %f.",
problem_ptr->n_constraints,
problem_ptr->n_variables,
problem_ptr->presolve_data.objective_offset);
Expand Down