Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding commit hash as an ARG and simple catboost build #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding commit hash as an ARG and simple catboost build #18

wants to merge 1 commit into from

Conversation

nvidia-johnq
Copy link
Contributor

No description provided.

trivialfis
trivialfis reviewed Oct 31, 2020
View reviewed changes
Dockerfile
@@ -1,4 +1,5 @@
ARG CUDA_VERSION
ARG XGB_HASH=6d293020fbfa2c67b532d550fe5d55689662caac
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to hard code this right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary so that we can explicitly invalidate the Docker layer and force recompile XGBoost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis left review comments

@hcho3 hcho3 hcho3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvidia-johnq @hcho3 @trivialfis