Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions #3

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

ArangoGutierrez
Copy link
Collaborator

This patch adds 2 github actions one for pull-request and one for push (post-merge)

.github/workflows/push.yaml Outdated Show resolved Hide resolved
.github/workflows/push.yaml Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

@cdesiniotis PTAL

elezar
elezar previously requested changes Feb 2, 2024
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/push.yaml Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez added the testing issue/PR to fix/edit/create/enhance a project unit/e2e test label Feb 27, 2024
@ArangoGutierrez ArangoGutierrez force-pushed the githubactions branch 16 times, most recently from c4f7a76 to 7b35383 Compare February 28, 2024 14:01
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions.

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the builds are working for 550 and precompiled, I am okay to merge this. We can address any follow-ups / improvements in a follow-up.

@ArangoGutierrez
Copy link
Collaborator Author

Since the builds are working for 550 and precompiled, I am okay to merge this. We can address any follow-ups / improvements in a follow-up.

Also remember that gitlab pipelines will continue to work in the mean time, so we are double covered for now

@ArangoGutierrez ArangoGutierrez merged commit b17c140 into NVIDIA:main Feb 28, 2024
4 checks passed
@ArangoGutierrez ArangoGutierrez deleted the githubactions branch February 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing issue/PR to fix/edit/create/enhance a project unit/e2e test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants