Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operatorsScore,supportedExprs for TruncDate, TruncTimestamp #11890

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mythrocks
Copy link
Collaborator

This change updates operatorsScore.csv and supportedExprs.csv to include TruncDate and TruncTimestamp, for all shim versions.

This seems to have been left out of #11833.

This change updates operatorsScore.csv and supportedExprs.csv to include `TruncDate` and `TruncTimestamp`, for all shim versions.

This seems to have been left out of NVIDIA#11833.

Signed-off-by: MithunR <mithunr@nvidia.com>
@mythrocks mythrocks self-assigned this Dec 18, 2024
@mythrocks mythrocks added the documentation Improvements or additions to documentation label Dec 18, 2024
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mythrocks
Copy link
Collaborator Author

Build

@gerashegalov
Copy link
Collaborator

This seems to have been left out of #11833.

Then this needs an issue because it should not pass pre-merge this way

@mythrocks
Copy link
Collaborator Author

This seems to have been left out of #11833.

Then this needs an issue because it should not pass pre-merge this way

#11896 has been filed to address the larger problem.

@mythrocks mythrocks merged commit ea007da into NVIDIA:branch-25.02 Dec 19, 2024
51 of 53 checks passed
@mythrocks mythrocks deleted the trunc-date-doc-update branch December 19, 2024 22:35
@mythrocks
Copy link
Collaborator Author

Thank you for the review, @abellina, @gerashegalov. I've merged this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants