Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing default settings in GpuJsonReadCommon.cudfJsonOptions() and consolidate creating cudf JSON reader options #11899

Open
jihoonson opened this issue Dec 20, 2024 · 1 comment

Comments

@jihoonson
Copy link
Collaborator

jihoonson commented Dec 20, 2024

This function takes a org.apache.spark.sql.catalyst.json.JSONOptions, and creates a new ai.rapids.cudf.JSONOptions based on the input JSON options with some default settings the plugin uses. Currently, there seem some default settings missing, such as withLines(true) as suggested in #11898 (comment). We should add all missing default options there. We also should consolidate creating the ai.rapids.cudf.JSONOptions across the whole code base.

@jihoonson
Copy link
Collaborator Author

jihoonson commented Dec 20, 2024

Note that #11898 introduces a new util function that returns a ai.rapids.cudf.JSONOptions.Builder with default options. We could add missing options in that function once the PR is merged. Also consider renaming the new function based on the discussion in #11898 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant