Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Better precision range for decimal multiply, and possibly others #1571

Closed
revans2 opened this issue Jan 22, 2021 · 1 comment
Closed
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Jan 22, 2021

Is your feature request related to a problem? Please describe.
Spark does some odd things when it comes to decimal multiply as you can see from #1564 It would be really great if we could work with Apache Spark, or possibly cudf to solve this problem in some way.

Describe the solution you'd like
I see two possibilities.

  1. We work with Apache Spark to make it so there is a clear and simple way tell what the original values were, or we strip out the unneeded manipulations in the first place.
  2. We work with cudf so that we can combine decimal multiply, INT divide, etc so we can do the operation at a very large precision and then scale it down at the end to match what spark does.

Describe alternatives you've considered
Magic???

Additional context
None

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 22, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 26, 2021
@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 18, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Dec 7, 2021

This was done as a part of the decimal 128 work

@revans2 revans2 closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants