Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing const for DDGIVolume::GetScrollOffsets() #69

Closed
Iyeyasu opened this issue Jan 12, 2023 · 1 comment
Closed

Missing const for DDGIVolume::GetScrollOffsets() #69

Iyeyasu opened this issue Jan 12, 2023 · 1 comment
Assignees
@acmarrs-nvidia
Labels
enhancement New feature or request

Comments

@Iyeyasu
Copy link

Iyeyasu commented Jan 12, 2023

The GetScrollOffsets() in DDGIVolume.h function is missing const, even though it is just a plain getter. This makes it harder to use in const-correct user code. Not a huge deal due to const_cast but should still be fixed.
@acmarrs-nvidia acmarrs-nvidia self-assigned this Jan 13, 2023
@acmarrs-nvidia acmarrs-nvidia added the enhancement New feature or request label Jan 13, 2023
@acmarrs-nvidia
Copy link
Contributor

Hi @Iyeyasu - thanks for pointing this out. I've included the fix in the v1.3.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acmarrs-nvidia acmarrs-nvidia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acmarrs-nvidia @Iyeyasu