Fix invalid argument for DX12 CreateHeap #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks! One suggestion, rewrite the heap tier test like so: if (ResourceHeapTier == TIER_1)
Flags = ONLY_RT_DS_TEXTURES;
else
Flags = ALL_BUFFERS_AND_TEXTURES;So that if a heap tier 3 is ever added, it won't break the existing code. |
|
Sounds good. Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a heap tier check because the
D3D12_HEAP_FLAG_ALLOW_ALL_BUFFERS_AND_TEXTURESflag is not supported for heap tier 1. I tested this on Windows 10 SDK 10.0.19041.0 and 10.0.20348.0.