Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses are missing on projects/show #1185

Open
hannahkates opened this issue Mar 16, 2020 · 7 comments
Open

Addresses are missing on projects/show #1185

hannahkates opened this issue Mar 16, 2020 · 7 comments
Assignees
Labels
High ROI High impact, low level of effort. Used for work prioritization. P2 Priority 2 enhancement according to Product Owner Regression Web API Experiment

Comments

@hannahkates
Copy link
Contributor

hannahkates commented Mar 16, 2020

There is a limit to the total number of expansions you can do (5).

image.png

@allthesignals
Copy link
Collaborator

I was thinking, i could grab these through the BBLs asynchronously. we at least have the bbls. I could query carto pluto for those.

@allthesignals
Copy link
Collaborator

we could also just grab this data direct from crm api asynchronously. the only reason they aren't showing up is i can only inner join 5 entities in a single request. a subsequent req wwould work:

/projects/:id/addresses

@hannahkates
Copy link
Contributor Author

@allthesignals Async is probably best. I think we have the use the official, preferred addresses stored in ZAP CRM. They can be different than the ones provided per BBL in MapPLUTO and there isn't always a 1-1 relationship between BBLs on a project and addresses on a project.

@allthesignals
Copy link
Collaborator

makes sense. easy to do an async endpoint for those.

@allthesignals
Copy link
Collaborator

Create a projects/:id/addresses endpoint in backend, and have frontend request this resource

@hannahkates hannahkates added the High ROI High impact, low level of effort. Used for work prioritization. label Apr 8, 2020
@trbmcginnis
Copy link
Contributor

@allthesignals Should the buildout of this new endpoint wait until we update labs-zap-api to connect directly to CRM? So that I'm not building out this endpoint using the old method

@trbmcginnis trbmcginnis added the Blocked An issue blocked by an external factor label Apr 9, 2020
@hannahkates
Copy link
Contributor Author

@trbmcginnis This problem isn't on production with the existing live API. It's caused by the new Web API implementation, so the fix would be within the same branch as the new Web API implementation.

@hannahkates hannahkates added this to the Sprint H milestone Apr 15, 2020
@hannahkates hannahkates removed this from the Sprint H milestone Apr 29, 2020
@hannahkates hannahkates added P2 Priority 2 enhancement according to Product Owner and removed Blocked An issue blocked by an external factor labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High ROI High impact, low level of effort. Used for work prioritization. P2 Priority 2 enhancement according to Product Owner Regression Web API Experiment
Projects
None yet
Development

No branches or pull requests

3 participants