-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses are missing on projects/show #1185
Comments
I was thinking, i could grab these through the BBLs asynchronously. we at least have the bbls. I could query carto pluto for those. |
we could also just grab this data direct from crm api asynchronously. the only reason they aren't showing up is i can only inner join 5 entities in a single request. a subsequent req wwould work:
|
@allthesignals Async is probably best. I think we have the use the official, preferred addresses stored in ZAP CRM. They can be different than the ones provided per BBL in MapPLUTO and there isn't always a 1-1 relationship between BBLs on a project and addresses on a project. |
makes sense. easy to do an async endpoint for those. |
Create a projects/:id/addresses endpoint in backend, and have frontend request this resource |
@allthesignals Should the buildout of this new endpoint wait until we update labs-zap-api to connect directly to CRM? So that I'm not building out this endpoint using the old method |
@trbmcginnis This problem isn't on production with the existing live API. It's caused by the new Web API implementation, so the fix would be within the same branch as the new Web API implementation. |
There is a limit to the total number of expansions you can do (5).
The text was updated successfully, but these errors were encountered: