-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error on CentOS #2
Comments
@gsdevme, apologies for the late reply! Thank you for taking the time to surface this issue! I'll have a look at this and try to get back to you tomorrow. At first glance, it appears you've got everything right and I may have introduced an error into one of the m4 macros. In the meantime, can you confirm that If this turns out to be the issue and you found the documentation ambiguous/confusing in this regard, please do not hesitate to say so and I'll try to update the language to make this distinction more apparent. Thanks again! |
Oh, regarding Travis tests: Yes, and this is long overdue. The effort involved is minimal. I'll see what I can do about getting some time allocated to set this up and get back to you. Thanks! |
Hey thanks for getting back to me @andrew-canaday I can submit a PR for adding Travis with different platforms (CentOS/Ubuntu/Debian) via KitchenCI then we can if there is some specific issue with a platform or my error it will be visible. |
Having a look at this today. Will also have a peek at the pull request (thank you!), but going to address them separately. In the meantime, toward diagnosing the issue you're experiencing, any chance you can post back with the output of |
The contents is on the PR
…Sent from my iPhone
On 1 Feb 2018, at 18:29, Andrew Canaday ***@***.***> wrote:
Having a look at this today. Will also have a peek at the pull request (thank you!), but going to address them separately.
In the meantime, toward diagnosing the issue you're experiencing, any chance you can post back with the output of ls /usr/include/varnish?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Aha! Gotcha, thank you! #!/usr/bin/env bash
# Download and extract varnish:
wget https://github.com/varnishcache/varnish-cache/archive/varnish-4.1.9.tar.gz
tar -xzf ./varnish-4.1.9.tar.gz
pushd ./varnish-cache-varnish-4.1.9/
# Save VARNISHSRC path for use later:
export VARNISHSRC="${PWD}"
# Configure and build:
# NOTE: you can skip the "make install" if you're working on a system
# which already has this version of varnish installed somewhere
# where the runtime library loader will find libvmod.so.
./autogen.sh && ./configure && make && make install && popd
# Exit directory and cd into your libvmod-queryfilter directory:
cd ./libvmod-queryfilter
./autogen.sh && ./configure VARNISHSRC="${VARNISHSRC}" && make && make check
# EOF I'll update the documentation to make this more clear. :D |
Interesting, I will check later tonight (GMT). Thanks though, I will update the PR also
…Sent from my iPhone
On 1 Feb 2018, at 18:48, Andrew Canaday ***@***.***> wrote:
Aha! Gotcha, thank you!
So it appears you are building against the varnish includes, not the varnish source. Try the following:
#!/usr/bin/env bash
# Download and extract varnish:
wget https://github.com/varnishcache/varnish-cache/archive/varnish-4.1.9.tar.gz
tar -xzf ./varnish-4.1.9.tar.gz
pushd ./varnish-cache-varnish-4.1.9/
# Save VARNISHSRC path for use later:
export VARNISHSRC="${PWD}"
# Configure and build:
./autogen.sh && ./configure && make && make install && popd
# Exit directory and cd into your libvmod-queryfilter directory:
cd ./libvmod-queryfilter
./autogen.sh && ./configure VARNISHSRC="${VARNISHSRC}" && make && make check
# EOF
I'll update the documentation to make this more clear. :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closing this; will have a look at the PR after the update. Thanks! |
Re-opened, because it appears the problem is persisting. |
|
Hey any chance the above highlights anything obvious? |
@gsdevme Apologies (again) for the delay. The sluggish responses have been something of an aberration. Thank you for your patience. I will have a look and get back to you Monday/Tuesday this week. |
@gsdevme Looks like there was an empty case in the configure script (sorry for your troubles, but thank you for surfacing this!). I pushed an update to master (specifically commit 5be34...) - give it a go and ping if you run into further issues. I'll cut a new release this weekend. |
Thanks, I will take a look |
Hi,
Is there any specific instructions for building on CentOS? Im using the devel files from the official Varnish package. This is with
varnish-4.1.9 revision 5024f60c3a51f537279977989b645e983a946e1a)
I've tried Master and every v2 release.
Is there any appetite to add travis tests? Id be happy to add if I can resolve my above issue. Furthermore packaging some RPM's could be ideal also
The text was updated successfully, but these errors were encountered: