Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atac window closing immediately #2

Open
urizennnn opened this issue Aug 10, 2024 · 9 comments
Open

Atac window closing immediately #2

urizennnn opened this issue Aug 10, 2024 · 9 comments

Comments

@urizennnn
Copy link

urizennnn commented Aug 10, 2024

When i try to run the Atac command in my nvim session the window pops up and immediately closes.

Video

2024-08-10.01-57-08.mp4
@NachoNievaG
Copy link
Owner

NachoNievaG commented Aug 10, 2024

Hi! Thanks for sharing.
I'm currently in a business trip, so if this requires immediate code fix, it might be delayed until to Tuesday.
Is there a chance you could provide:

  • OS
  • NVIM version
  • ATAC version
  • if you have or not the config.toml file in your $HOME/atac dir?

@urizennnn
Copy link
Author

Hi! Thanks for sharing. I'm currently in a business trip, so if this requires immediate code fix, it might be delayed until to Tuesday. Is there a chance you could provide:

  • OS
  • NVIM version
  • ATAC version
  • if you have or not the config.toml file in your $HOME/atac dir?

I use arch linux
nvim version is 0.10.1
atac version is 0.16.0 installed from pacman , cargo returns errors which suggest that
ratatui versions are not consistent somewhere and that the Image type doesn't implement the Widget trait or consider using an alternative type that does.

@NachoNievaG
Copy link
Owner

I'll be looking at this next week

@Olprog59
Copy link

Hello,
I installed Atac today as well as this plugin. I had the same problem. It was due to the folder not existing.
In order to adapt it to my projects, I told it that I wanted it to open in my projects folder + "/atac".
Here's my configuration:

return {
  "NachoNievaG/atac.nvim",
  dependencies = { "akinsho/toggleterm.nvim" },
  config = function()
    require("atac").setup({
      dir = vim.fn.getcwd() .. "/atac",
    })
  end,
}

@NachoNievaG
Copy link
Owner

Great, I will be changing the approach of checking the dir is existent to handle this scenario. Thanks for the input @Olprog59 . @urizennnn could you try this by any chance?

@urizennnn
Copy link
Author

Great, I will be changing the approach of checking the dir is existent to handle this scenario. Thanks for the input @Olprog59 . @urizennnn could you try this by any chance?

I haven't created an nvim plugin before but i would love to contribute

@urizennnn
Copy link
Author

urizennnn commented Aug 10, 2024

@NachoNievaG so i thought i had a fix while testing but the plugin (untouched) seems to work in the atac.nvim dir but not in another project folder, after a deep dive i found out that the problem is from atac not the plugin
it works perfectly in a directory with no .json file but if another directory and any .json file exists in it. the window will close

@NachoNievaG
Copy link
Owner

NachoNievaG commented Aug 10, 2024

Okay, I'll reference it to the guys at ATAC, I might be able to drive through a fix. Keeping you updated in this issue
EDIT: I've seen you already did, so let's keep it together there, thank you

@urizennnn
Copy link
Author

Okay, I'll reference it to the guys at ATAC, I might be able to drive through a fix. Keeping you updated in this issue

alright
i might still try to outdo myself and look at the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants