Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard interrupt; Continue to next image doesn't work in fanbox mode. #1020

Closed
3 tasks done
NHOrus opened this issue Oct 3, 2021 · 6 comments
Closed
3 tasks done

Comments

@NHOrus
Copy link
Contributor

NHOrus commented Oct 3, 2021

Prerequisites

Description

[Description of the bug or feature]

Steps to Reproduce

  1. Start downloading Supported Artists from Fanbox with f1
  2. Press Ctrl-C in the middle of the process
  3. PixivUtil2 reports "Keyboard interrupt detected, continue to next post (y/n) ?
  4. Press n

Expected behavior: [What you expected to happen]
PixivUtil2 doesn't continue to next post and goes to next supported artist, similar to download from list.

Actual behavior: [What actually happened]
Download of the post resumes.

Versions

20210822

@bluerthanever
Copy link
Contributor

I remembered that i implemented this already...?

@bluerthanever
Copy link
Contributor

except KeyboardInterrupt:
choice = input("Keyboard Interrupt detected, continue to next post (Y/N)").rstrip("\r")
if choice.upper() == 'N':
PixivHelper.print_and_log("info", f"FANBOX artist: {artist}, processing aborted")
break

here it is~~
maybe keyboard interruption was triggered outside post processing?

@NHOrus
Copy link
Contributor Author

NHOrus commented Oct 13, 2021

It breaks out of for loop processing post and continues with same artist in same while loop.

So, it tells that processing artist is aborted and continues with next post.

@bluerthanever
Copy link
Contributor

hmm... there does seem to be something logically wrong, now that i look at it.
i think if you enter "n" now, it goes to next page.

@bluerthanever
Copy link
Contributor

sorry. should be fixed in #1026.

@NHOrus
Copy link
Contributor Author

NHOrus commented Oct 14, 2021

Looks correct

@Nandaka Nandaka closed this as completed Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants